ian/Skyblock-Bazaar-Flipping-Calculator
1
0
Fork 0
Code Issues Pull requests Activity

Add an option to remove potentially manipulated items #9

New issue
Closed
opened 2023-05-13 06:30:11 +00:00 by ethanready · 4 comments
ethanready commented 2023-05-13 06:30:11 +00:00 (Migrated from github.com)
Copy link

You could check the difference in buy and sell price of an item every hour over the last day to get an average, and then if the difference was greater than 120% of the average difference, it would be suspected that the item was manipulated and you could exclude it

You could check the difference in buy and sell price of an item every hour over the last day to get an average, and then if the difference was greater than 120% of the average difference, it would be suspected that the item was manipulated and you could exclude it
ianrenton commented 2023-05-13 13:17:37 +00:00 (Migrated from github.com)
Copy link

That does sound like a useful feature if that kind of manipulation is a problem. My only concern is that the user is unlikely to leave the web page open for a whole day! There's not any server-side code here, it all runs in the user's browser, so adding anything server-side is a pretty significant change. This feature therefore might be better suited to one of the other bazaar calculators out there that already run server-side. However, if you fancy working on it for this one, I would consider taking a PR and hosting the code on a server somewhere.

That does sound like a useful feature if that kind of manipulation is a problem. My only concern is that the user is unlikely to leave the web page open for a whole day! There's not any server-side code here, it all runs in the user's browser, so adding anything server-side is a pretty significant change. This feature therefore might be better suited to one of the other bazaar calculators out there that already run server-side. However, if you fancy working on it for this one, I would consider taking a PR and hosting the code on a server somewhere.
ethanready commented 2023-05-13 14:51:41 +00:00 (Migrated from github.com)
Copy link

oh, yeah, i suppose thats a good point. mby i'll fork and see if i can find another way to do this

oh, yeah, i suppose thats a good point. mby i'll fork and see if i can find another way to do this
ianrenton commented 2023-05-19 15:35:01 +00:00 (Migrated from github.com)
Copy link

Can this issue be closed now PR #11 is merged?

Can this issue be closed now PR #11 is merged?
ethanready commented 2023-05-19 15:36:10 +00:00 (Migrated from github.com)
Copy link

yeah

yeah
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ian/Skyblock-Bazaar-Flipping-Calculator#9
No description provided.