Filter by items in the offer #16
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Built a feature that I wanted to use personally. Thought I'd offer it here in case you want it.
I don't like dealing with bulk bazaar offers so I added this filter to add a max filter to orders.
Example:
Maximum of 64 per offer:
1000x Red sand - Filtered out
3x Super Compactor - Allowed
64x Enchanted Beef - Allowed
Action that may be required if this is to be approved:
There is a bug when using this with multiple offer where it will only limit the quantity of the final offer that I did not feel like fixing.
The orders of class names for the missingItems is out of order.
My writing isn't the best so the titles/tooltips of the feature may need a rewrite.
I also just added localstorage to the fields so it remembers your last search when you open it again.
Hi, thanks for contributing! Definitely looks like a useful new feature (as does the local storage). One possibly silly question: does it make sense to filter out items where the quantity would be over the limit, or should they just appear in the table as normal, but with the number to trade capped at the limit you set? I'd have thought it should be the second option, i.e. you can still make some profit on the item with the limit in place, just not as much as with the full amount. (Note I don't actually play Skyblock, this was just a thing I made to help my daughter, so if filtering out items does make more sense than my idea, please let me know and I will merge!)
Thanks for getting back to me. I assumed that anything that goes over that trade limit, wouldn't be able to out-profit the items if they were to be lowered to that trade amount. This is likely incorrect and a different implementation is likely better but filtering was easier for me to build quickly. This filter might be more of a personal preference than an a useful filter so leaving it out is fine.
The local storage is definitely something I recommend to merge into the main project. It's really nice to close the tab when you are done playing and then when you come back it has all your preferences saved. I can make a separate branch on this repo with just the localstorage changes if you'd like.
That's really cool that you built this for your daughter. Thanks for making it public as well, I have found it to be super helpful.
No problem. I will definitely merge this branch (thank you!), no need to fiddle around making others. I might play around with it after merge and see what the results look like if the limit is just treated as a limit rather than a reason to exclude.