ian/spothole
2
1
Fork 0
Code Issues 20 Pull requests Projects Releases 5 Packages Wiki Activity Actions

get_sig_ref_info is ugly #74

New issue
Closed
opened 2025-11-02 13:59:45 +00:00 by ian · 0 comments
ian commented 2025-11-02 13:59:45 +00:00
Owner
Copy link

In order to perform a lookup of sig_ref_info without instantiating Spot Provider objects, get_sig_ref_info in sig_utils.py has its own cache for the same URLs that are looked up elsewhere, and generally copies functionality that is in Spot Providers.

It would be nice to refactor this out so that there is e.g. a generic POTA utils area that is used by the POTA Spot Provider and by get_sig_ref_info; repeat for the other SIGs.

We could also move to having a single application-wide URL lookup cache.

In order to perform a lookup of sig_ref_info without instantiating Spot Provider objects, get_sig_ref_info in sig_utils.py has its own cache for the same URLs that are looked up elsewhere, and generally copies functionality that is in Spot Providers. It would be nice to refactor this out so that there is e.g. a generic POTA utils area that is used by the POTA Spot Provider and by get_sig_ref_info; repeat for the other SIGs. We could also move to having a single application-wide URL lookup cache.
ian closed this issue 2025-11-02 15:45:25 +00:00
ian referenced this issue from a commit 2025-11-02 17:59:40 +00:00
Exception handling #74
ian referenced this issue from a commit 2025-11-02 18:00:27 +00:00
Exception handling #74
ian added this to the 1.0 milestone 2025-11-09 07:28:41 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
web_ui_options_faff
97-wwtota
88-colour-schemes
3-sse-endpoints
82-tota
73-hamqth-lookup
1.2
1.1.1
1.1
1.0.1
1.0
Labels
Clear labels   
blocked

   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
maybe

Not sure if I definitely want to implement this

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
blocked
bug
duplicate
enhancement
help wanted
invalid
maybe
question
wontfix
Milestone
Clear milestone
No items
No milestone
1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ian/spothole#74
No description provided.